Skip to content

Add workflow to check pyfftw#7

Open
NimaSarajpoor wants to merge 33 commits intostumpy-dev:mainfrom
NimaSarajpoor:stumpy_actions_with_pixi
Open

Add workflow to check pyfftw#7
NimaSarajpoor wants to merge 33 commits intostumpy-dev:mainfrom
NimaSarajpoor:stumpy_actions_with_pixi

Conversation

@NimaSarajpoor
Copy link

No description provided.

@gitnotebooks
Copy link

gitnotebooks bot commented Jan 29, 2026

Review these changes at https://app.gitnotebooks.com/stumpy-dev/automate/pull/7

@NimaSarajpoor NimaSarajpoor force-pushed the stumpy_actions_with_pixi branch from 0976d65 to f869860 Compare January 29, 2026 07:54
@NimaSarajpoor NimaSarajpoor force-pushed the stumpy_actions_with_pixi branch from 412afe3 to b0c848d Compare January 29, 2026 08:04
@NimaSarajpoor
Copy link
Author

@seanlaw
Apologies for the noise!

I've generated API Key from my account in prefix.dev and saved it in a secret, and used it in the yml file. See Github Actions Run in the forked repo.

@seanlaw
Copy link
Contributor

seanlaw commented Jan 29, 2026

@NimaSarajpoor When I go to:

Settings > Secrets and Variables > Actions

It states:

Anyone with collaborator access to this repository can use these secrets and variables for actions. They are not passed to workflows that are triggered by a pull request from a fork.

So, I believe that the workflow needs to be merged first before it can have access to the token

@NimaSarajpoor
Copy link
Author

@seanlaw

They are not passed to workflows that are triggered by a pull request from a fork.

So, I believe that the workflow needs to be merged first before it can have access to the token

Makes sense! Thanks for checking that out.

@NimaSarajpoor NimaSarajpoor changed the title Install dependencies via pixi and run the tests Check pyfftw Feb 1, 2026
@NimaSarajpoor NimaSarajpoor changed the title Check pyfftw Add workflow to check pyfftw Feb 1, 2026
@NimaSarajpoor
Copy link
Author

NimaSarajpoor commented Feb 1, 2026

@seanlaw
Okay... I think I should finish the sdp PR in STUMPY (stumpy-dev/stumpy#1118) first, and then gets successful run there (without checking pyfftw if it is not installed).... and then, after merging that PR, come back here.

@seanlaw
Copy link
Contributor

seanlaw commented Feb 4, 2026

I believe that the workflow needs to be merged first before it can have access to the token

I was totally wrong! A token is not needed in our case. A pixi token is only needed if you are managing packages at prefix.dev. I want to add a workflow for checking conda-forge builds using pixi (similar to checking our pypi builds). So I will test that out

@seanlaw
Copy link
Contributor

seanlaw commented Feb 4, 2026

@NimaSarajpoor We now have a pixi workflow that checks conda-forge;

https://github.com/stumpy-dev/automate/blob/main/.github/workflows/check-conda-forge-actions.yml

Hopefully, that helps you with this

@NimaSarajpoor
Copy link
Author

@seanlaw

A pixi token is only needed if you are managing packages at prefix.dev.

👍

We now have a pixi workflow that checks conda-forge;
Hopefully, that helps you with this

Thanks for the work on this! A couple of questions:

(1) Do you suggest that we should use pixi instead of pip for installing STUMPY (and its dependencies)? and then install pyfftw and FFTW on top of those ?

(2) Are we planning to avoid using specific versions for setup-pixi and pixi in the future?

- name: Set Up Pixi
uses: prefix-dev/setup-pixi@v0.9.4
with:
pixi-version: v0.62.2

@seanlaw
Copy link
Contributor

seanlaw commented Feb 4, 2026

(1) Do you suggest that we should use pixi instead of pip for installing STUMPY (and its dependencies)? and then install pyfftw and FFTW on top of those ?

Yes, use pixi to install STUMPY and its dependencies. Then either add a workflow "step" to pixi add pyfftw fftw OR figure out how to add them to the pyproject.toml. The latter might be harder?

(2) Are we planning to avoid using specific versions for setup-pixi and pixi in the future?

Yes, we'll update it once setup-pixi stabilizes. I don't want to use dependabot. It's okay if the pixi-related workflows fail in the future. Note that I haven't fully confirmed that my steps are correct (in terms of whether or not I have successfully avoided installing STUMPY from source and, instead, installed it from conda-forge. I am 95% sure? Please take a look :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants